Open
Conversation
Contributor
|
Hey! Thanks for the PR. I think we should pass the |
Contributor
Author
|
Done |
Contributor
|
Hey! Sorry I missed the removal of |
Contributor
Author
|
Actually I read the issue linked and agreed with the thinking, since they
are about the same lines, I though to get two birds with one stone.
…On Fri, Oct 27, 2023, 17:18 Jonathan Poole ***@***.***> wrote:
Hey! Sorry I missed the removal of -Wno-error. Why should we change this
behavior? We're compiling a lot of generated code here and I'm a little
worried it's going to end up failing fairly regularly?
—
Reply to this email directly, view it on GitHub
<#169 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQB2YFSBH3I4FVSIAPCQTDYBPGFRAVCNFSM6AAAAAA6RKHNYCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGA4TGMBTHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Contributor
|
Makes sense. The removal of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello this is two simple fix that make go_rules work better in cgo mode
Add _module parameter generated by please_go
see #164 (comment)
Remove -Wno-error, include PKG_DIR
Fix #149
cc_library include . (-I .) but cgo put all files in PKG_DIR